pvillard31 commented on a change in pull request #5479:
URL: https://github.com/apache/nifi/pull/5479#discussion_r736262670
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenSyslog.java
##########
@@ -183,6 +183,16 @@
.defaultValue(ClientAuth.REQUIRED.name())
.dependsOn(SSL_CONTEXT_SERVICE)
.build();
+ public static final PropertyDescriptor SOCKET_KEEP_ALIVE = new
PropertyDescriptor.Builder()
+ .name("socket-keep-alive")
+ .displayName("Socket Keep Alive")
+ .description("Whether or not to have TCP socket keep alive turned
on. Timing details depend on operating system properties.")
+ .required(false)
+ .addValidator(StandardValidators.BOOLEAN_VALIDATOR)
+ .allowableValues(Boolean.TRUE.toString(), Boolean.FALSE.toString())
+ .defaultValue(Boolean.FALSE.toString())
+ .dependsOn(PROTOCOL, TCP_VALUE)
+ .build();
Review comment:
Very minor comment but I believe we're usually saying
``.required(true)`` for properties with a list of allowable values and a
default value. See ``PARSE_MESSAGES``. I'm fine merging as-is though. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
