adamdebreceni commented on a change in pull request #1203:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1203#discussion_r738156449



##########
File path: msi/WixWin.wsi
##########
@@ -113,6 +117,7 @@ Licensed to the Apache Software Foundation (ASF) under one 
or more
 
       <Publish Dialog="MaintenanceWelcomeDlg" Control="Next" Event="NewDialog" 
Value="MaintenanceTypeDlg">1</Publish>
 
+      <Publish Dialog="MaintenanceTypeDlg" Control="ChangeButton" 
Event="NewDialog" Value="ApacheLicenseDlg">1</Publish>

Review comment:
       since the user might select new extension to be added I felt like the 
same legal requirements apply as during a fresh install, IANAL so if it is not 
required I'll remove it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to