mikayla-yang commented on pull request #5476: URL: https://github.com/apache/nifi/pull/5476#issuecomment-957072411
@markap14 @exceptionfactory Thank you for the comments! I have made changes according to your reviews. @markap14 For handling the failure conditions, I made the change based on your suggestion and also referred to the logic of GeoEnrichIPRecord. I didn’t refactor the code to use the Map structure as we discussed because for the _Require_All_Enriched_ routing strategy, we will not know which RecordSetWriter to use until we finish processing all records. However, using the Map structure requires us to know the final relationship every time we write a record in order to use a proper RecordSetWriter. LISCENCE and NOTICE files have been added in the NAR module. The NOTICE under nifi-assembly has been updated as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
