szaszm commented on a change in pull request #1168:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1168#discussion_r740826733
##########
File path: cmake/BuildTests.cmake
##########
@@ -111,6 +111,11 @@ FOREACH(testfile ${UNIT_TESTS})
target_link_libraries(${testfilename} ${CATCH_MAIN_LIB})
MATH(EXPR UNIT_TEST_COUNT "${UNIT_TEST_COUNT}+1")
add_test(NAME "${testfilename}" COMMAND "${testfilename}" WORKING_DIRECTORY
${TEST_DIR})
+ if (WIN32)
+ target_compile_options(${testfilename} PRIVATE "/W")
+ else()
+ target_compile_options(${testfilename} PRIVATE "-w")
+ endif()
Review comment:
I just realized that there is also `[[maybe-unused]]`.
https://en.cppreference.com/w/cpp/language/attributes/maybe_unused
I'm fine with either solution, but this is compiler-independent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
