[ 
https://issues.apache.org/jira/browse/MINIFICPP-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marton Szasz updated MINIFICPP-1679:
------------------------------------
    Description: 
With GCC 8 and 9:
In file included from 
/home/szaszm/nifi-minifi-cpp/libminifi/test/unit/../Catch.h:21,
                 from 
/home/szaszm/nifi-minifi-cpp/libminifi/test/unit/RelationshipTests.cpp:20:
/home/szaszm/nifi-minifi-cpp/libminifi/test/unit/RelationshipTests.cpp: In 
function ‘void ____C_A_T_C_H____T_E_S_T____0()’:
/home/szaszm/nifi-minifi-cpp/libminifi/test/unit/RelationshipTests.cpp:31:23: 
error: no match for ‘operator!=’ (operand types are ‘const 
org::apache::nifi::minifi::core::Relationship’ and ‘const 
org::apache::nifi::minifi::core::Relationship’)
   REQUIRE(!(undefined != undefined));
             ~~~~~~~~~~^~~~~~~~~~~~

Caused by a change in MINIFICPP-1634. It was not caught by the CI because the 
error is in a test, and we build on debian with -DSKIP_TESTS=ON.

  was:
With GCC 8 and 9:
In file included from 
/home/szaszm/nifi-minifi-cpp/libminifi/test/unit/../Catch.h:21,
                 from 
/home/szaszm/nifi-minifi-cpp/libminifi/test/unit/RelationshipTests.cpp:20:
/home/szaszm/nifi-minifi-cpp/libminifi/test/unit/RelationshipTests.cpp: In 
function ‘void ____C_A_T_C_H____T_E_S_T____0()’:
/home/szaszm/nifi-minifi-cpp/libminifi/test/unit/RelationshipTests.cpp:31:23: 
error: no match for ‘operator!=’ (operand types are ‘const 
org::apache::nifi::minifi::core::Relationship’ and ‘const 
org::apache::nifi::minifi::core::Relationship’)
   REQUIRE(!(undefined != undefined));
             ~~~~~~~~~~^~~~~~~~~~~~


> Revert Relationship::operator!=, because GCC < 10 doesn't support consistent 
> comparison
> ---------------------------------------------------------------------------------------
>
>                 Key: MINIFICPP-1679
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-1679
>             Project: Apache NiFi MiNiFi C++
>          Issue Type: Bug
>            Reporter: Marton Szasz
>            Assignee: Marton Szasz
>            Priority: Minor
>
> With GCC 8 and 9:
> In file included from 
> /home/szaszm/nifi-minifi-cpp/libminifi/test/unit/../Catch.h:21,
>                  from 
> /home/szaszm/nifi-minifi-cpp/libminifi/test/unit/RelationshipTests.cpp:20:
> /home/szaszm/nifi-minifi-cpp/libminifi/test/unit/RelationshipTests.cpp: In 
> function ‘void ____C_A_T_C_H____T_E_S_T____0()’:
> /home/szaszm/nifi-minifi-cpp/libminifi/test/unit/RelationshipTests.cpp:31:23: 
> error: no match for ‘operator!=’ (operand types are ‘const 
> org::apache::nifi::minifi::core::Relationship’ and ‘const 
> org::apache::nifi::minifi::core::Relationship’)
>    REQUIRE(!(undefined != undefined));
>              ~~~~~~~~~~^~~~~~~~~~~~
> Caused by a change in MINIFICPP-1634. It was not caught by the CI because the 
> error is in a test, and we build on debian with -DSKIP_TESTS=ON.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to