tpalfy commented on a change in pull request #5088:
URL: https://github.com/apache/nifi/pull/5088#discussion_r741980742
##########
File path:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/GetSNMP.java
##########
@@ -134,59 +144,96 @@
REL_FAILURE
)));
+ private volatile GetSNMPHandler snmpHandler;
+
+ @OnScheduled
+ public void init(final ProcessContext context) {
+ initSnmpManager(context);
+ snmpHandler = new GetSNMPHandler(snmpResourceHandler);
+ }
+
@Override
public void onTrigger(final ProcessContext context, final ProcessSession
processSession) {
final SNMPStrategy snmpStrategy =
SNMPStrategy.valueOf(context.getProperty(SNMP_STRATEGY).getValue());
final String oid = context.getProperty(OID).getValue();
+ final FlowFile flowfile = processSession.get();
if (SNMPStrategy.GET == snmpStrategy) {
- performSnmpGet(context, processSession, oid);
+ performSnmpGet(context, processSession, oid, flowfile);
} else if (SNMPStrategy.WALK == snmpStrategy) {
- performSnmpWalk(context, processSession, oid);
+ performSnmpWalk(context, processSession, oid, flowfile);
}
}
- private void performSnmpWalk(final ProcessContext context, final
ProcessSession processSession, final String oid) {
+ void performSnmpWalk(final ProcessContext context, final ProcessSession
processSession, final String oid,
+ final FlowFile flowFile) {
+ final Optional<FlowFile> incomingFlowFile =
Optional.ofNullable(flowFile);
+ Map<String, String> flowFileAttributes =
incomingFlowFile.map(FlowFile::getAttributes).orElse(Collections.emptyMap());
try {
- final SNMPTreeResponse response = snmpRequestHandler.walk(oid);
- response.logErrors(getLogger());
- FlowFile flowFile =
createFlowFileWithTreeEventProperties(response, processSession);
- processSession.getProvenanceReporter().receive(flowFile,
response.getTargetAddress() + "/" + oid);
- processSession.transfer(flowFile, REL_SUCCESS);
+ final Optional<SNMPTreeResponse> optionalResponse =
snmpHandler.walk(oid, flowFileAttributes);
+ if (optionalResponse.isPresent()) {
+ incomingFlowFile.ifPresent(processSession::remove);
+ final SNMPTreeResponse response = optionalResponse.get();
+ response.logErrors(getLogger());
+ FlowFile outgoingFlowFile =
createFlowFileWithTreeEventProperties(response, processSession);
+
processSession.getProvenanceReporter().receive(outgoingFlowFile,
response.getTargetAddress() + "/walk");
+ processSession.transfer(outgoingFlowFile, REL_SUCCESS);
+ } else {
+ getLogger().warn("No SNMP specific attributes found in
flowfile.");
+ incomingFlowFile.ifPresent(ff -> processSession.transfer(ff,
REL_SUCCESS));
Review comment:
Shouldn't go to failure instead of success in this case?
##########
File path:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/properties/V1TrapProperties.java
##########
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.snmp.processors.properties;
+
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.processor.util.StandardValidators;
+
+import static
org.apache.nifi.snmp.processors.properties.BasicProperties.SNMP_V1;
+import static
org.apache.nifi.snmp.processors.properties.BasicProperties.SNMP_VERSION;
+
+
+public class V1TrapProperties {
+
+ private V1TrapProperties() {
+ // Utility class, not needed to instantiate.
+ }
+
+ private static final AllowableValue GENERIC_TRAP_TYPE_COLD_START = new
AllowableValue("0", "Cold Start",
+ "A coldStart trap signifies that the sending protocol entity is
reinitializing itself such that" +
+ " the agent's configuration or the protocol entity
implementation may be altered.");
+
+ private static final AllowableValue GENERIC_TRAP_TYPE_WARM_START = new
AllowableValue("1", "Warm Start",
+ "A warmStart trap signifies that the sending protocol entity is
reinitializing itself such that" +
+ " neither the agent configuration nor the protocol entity
implementation is altered.");
+
+ private static final AllowableValue GENERIC_TRAP_TYPE_LINK_DOWN = new
AllowableValue("2", "Link Down",
+ "A linkDown trap signifies that the sending protocol entity
recognizes a failure in one of " +
+ "the communication links represented in the agent's
configuration.");
+
+ private static final AllowableValue GENERIC_TRAP_TYPE_LINK_UP = new
AllowableValue("3", "Link Up",
+ "A linkUp trap signifies that the sending protocol entity
recognizes that one of the communication " +
+ "links represented in the agent's configuration has come
up.");
+
+ private static final AllowableValue GENERIC_TRAP_TYPE_AUTH_FAILURE = new
AllowableValue("4", "Authentication Failure",
+ "An authenticationFailure trap signifies that the sending protocol
entity is the addressee of a " +
+ "protocol message that is not properly authenticated.
While implementations of the SNMP must be " +
+ "capable of generating this trap, they must also be
capable of suppressing the emission of such traps " +
+ "via an implementation- specific mechanism.");
+
+ private static final AllowableValue GENERIC_TRAP_TYPE_EGP_NEIGHBOR_LOSS =
new AllowableValue("5", "EGP Neighbor Loss",
+ "An egpNeighborLoss trap signifies that an EGP neighbor for whom
the sending protocol entity was " +
+ "an EGP peer has been marked down and the peer
relationship no longer obtains.");
+
+ private static final AllowableValue GENERIC_TRAP_TYPE_ENTERPRISE_SPECIFIC
= new AllowableValue("6", "Enterprise Specific",
+ "An enterpriseSpecific trap signifies that a particular
enterprise-specific trap has occurred which " +
+ "can be defined in the Specific Trap Type field.");
+
+ public static final PropertyDescriptor ENTERPRISE_OID = new
PropertyDescriptor.Builder()
+ .name("snmp-trap-enterprise-oid")
+ .displayName("Enterprise OID")
+ .description("Enterprise is the vendor identification (OID) for
the network management sub-system that generated the trap.")
+ .required(true)
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+ .dependsOn(SNMP_VERSION, SNMP_V1)
+
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+ .build();
+
+ public static final PropertyDescriptor AGENT_ADDRESS = new
PropertyDescriptor.Builder()
+ .name("snmp-trap-agent-address")
+ .displayName("SNMP Trap Agent Address")
+ .description("The address where the SNMP Manager sends the trap.")
+ .required(true)
+ .defaultValue("0")
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+ .dependsOn(SNMP_VERSION, SNMP_V1)
+
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+ .build();
+
+ public static final PropertyDescriptor PREDEFINED_GENERIC_TRAP_TYPE = new
PropertyDescriptor.Builder()
Review comment:
Having both a drop-down list and a text-box for the same purpose is more
confusing than convenient in my opinion.
##########
File path:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SetSNMP.java
##########
@@ -74,30 +80,46 @@
private static final List<PropertyDescriptor> PROPERTY_DESCRIPTORS =
Collections.unmodifiableList(Arrays.asList(
AGENT_HOST,
AGENT_PORT,
- SNMP_VERSION,
- SNMP_COMMUNITY,
- SNMP_SECURITY_LEVEL,
- SNMP_SECURITY_NAME,
- SNMP_AUTH_PROTOCOL,
- SNMP_AUTH_PASSWORD,
- SNMP_PRIVACY_PROTOCOL,
- SNMP_PRIVACY_PASSWORD,
- SNMP_RETRIES,
- SNMP_TIMEOUT
+ BasicProperties.SNMP_VERSION,
+ BasicProperties.SNMP_COMMUNITY,
+ V3SecurityProperties.SNMP_SECURITY_LEVEL,
+ V3SecurityProperties.SNMP_SECURITY_NAME,
+ V3SecurityProperties.SNMP_AUTH_PROTOCOL,
+ V3SecurityProperties.SNMP_AUTH_PASSWORD,
+ V3SecurityProperties.SNMP_PRIVACY_PROTOCOL,
+ V3SecurityProperties.SNMP_PRIVACY_PASSWORD,
+ BasicProperties.SNMP_RETRIES,
+ BasicProperties.SNMP_TIMEOUT
));
private static final Set<Relationship> RELATIONSHIPS =
Collections.unmodifiableSet(new HashSet<>(Arrays.asList(
REL_SUCCESS,
REL_FAILURE
)));
+ private volatile SetSNMPHandler snmpHandler;
+
+ @OnScheduled
+ public void init(final ProcessContext context) {
+ initSnmpManager(context);
+ snmpHandler = new SetSNMPHandler(snmpResourceHandler);
+ }
+
@Override
public void onTrigger(final ProcessContext context, final ProcessSession
processSession) {
final FlowFile flowFile = processSession.get();
if (flowFile != null) {
try {
- final SNMPSingleResponse response =
snmpRequestHandler.set(flowFile);
- processResponse(processSession, flowFile, response,
response.getTargetAddress(), REL_SUCCESS);
+ final Optional<SNMPSingleResponse> optionalResponse =
snmpHandler.set(flowFile.getAttributes());
+ if (optionalResponse.isPresent()) {
+ processSession.remove(flowFile);
+ final FlowFile outgoingFlowFile = processSession.create();
+ final SNMPSingleResponse response = optionalResponse.get();
+ processResponse(processSession, outgoingFlowFile,
response, response.getTargetAddress() + "/set", REL_SUCCESS);
+ } else {
+ getLogger().warn("No SNMP specific attributes found in
flowfile.");
+ processSession.transfer(flowFile, REL_SUCCESS);
Review comment:
Shouldn't go to failure instead of success in this case?
##########
File path:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SendTrapSNMP.java
##########
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.snmp.processors;
+
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.snmp.configuration.V1TrapConfiguration;
+import org.apache.nifi.snmp.configuration.V2TrapConfiguration;
+import org.apache.nifi.snmp.factory.trap.V1TrapPDUFactory;
+import org.apache.nifi.snmp.factory.trap.V2TrapPDUFactory;
+import org.apache.nifi.snmp.operations.SendTrapSNMPHandler;
+import org.apache.nifi.snmp.processors.properties.BasicProperties;
+import org.apache.nifi.snmp.processors.properties.V1TrapProperties;
+import org.apache.nifi.snmp.processors.properties.V2TrapProperties;
+import org.apache.nifi.snmp.processors.properties.V3SecurityProperties;
+import org.snmp4j.PDU;
+import org.snmp4j.mp.SnmpConstants;
+
+import java.io.IOException;
+import java.time.Instant;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.function.Supplier;
+
+/**
+ * Sends data to an SNMP manager which, upon each invocation of
+ * {@link #onTrigger(ProcessContext, ProcessSession)} method, will construct a
+ * {@link FlowFile} containing in its properties the information retrieved.
+ * The output {@link FlowFile} won't have any content.
+ */
+@Tags({"snmp", "send", "trap"})
+@InputRequirement(Requirement.INPUT_ALLOWED)
+@CapabilityDescription("Sends information to SNMP Manager.")
+public class SendTrapSNMP extends AbstractSNMPProcessor {
+
+ public static final PropertyDescriptor SNMP_MANAGER_HOST = new
PropertyDescriptor.Builder()
+ .name("snmp-trap-manager-host")
+ .displayName("SNMP Manager Host")
+ .description("The host where the SNMP Manager sends the trap.")
+ .required(true)
+ .defaultValue("localhost")
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+ .build();
+
+ public static final PropertyDescriptor SNMP_MANAGER_PORT = new
PropertyDescriptor.Builder()
+ .name("snmp-trap-manager-port")
+ .displayName("SNMP Manager Port")
+ .description("The port where the SNMP Manager listens to the
incoming traps.")
+ .required(true)
+ .defaultValue("0")
+ .addValidator(StandardValidators.PORT_VALIDATOR)
+ .build();
+
+ public static final Relationship REL_SUCCESS = new Relationship.Builder()
+ .name("success")
+ .description("All FlowFiles that have been successfully used to
perform SNMP Set are routed to this relationship")
+ .build();
+
+ public static final Relationship REL_FAILURE = new Relationship.Builder()
+ .name("failure")
+ .description("All FlowFiles that cannot received from the SNMP
agent are routed to this relationship")
+ .build();
+
+ protected static final List<PropertyDescriptor> PROPERTY_DESCRIPTORS =
Collections.unmodifiableList(Arrays.asList(
+ SNMP_MANAGER_HOST,
+ SNMP_MANAGER_PORT,
+ BasicProperties.SNMP_VERSION,
+ BasicProperties.SNMP_COMMUNITY,
+ V3SecurityProperties.SNMP_SECURITY_LEVEL,
+ V3SecurityProperties.SNMP_SECURITY_NAME,
+ V3SecurityProperties.SNMP_AUTH_PROTOCOL,
+ V3SecurityProperties.SNMP_AUTH_PASSWORD,
+ V3SecurityProperties.SNMP_PRIVACY_PROTOCOL,
+ V3SecurityProperties.SNMP_PRIVACY_PASSWORD,
+ BasicProperties.SNMP_RETRIES,
+ BasicProperties.SNMP_TIMEOUT,
+ V1TrapProperties.ENTERPRISE_OID,
+ V1TrapProperties.AGENT_ADDRESS,
+ V1TrapProperties.PREDEFINED_GENERIC_TRAP_TYPE,
+ V1TrapProperties.GENERIC_TRAP_TYPE,
+ V1TrapProperties.SPECIFIC_TRAP_TYPE,
+ V2TrapProperties.TRAP_OID_VALUE
+ ));
+
+ private static final Set<Relationship> RELATIONSHIPS =
Collections.unmodifiableSet(new HashSet<>(Arrays.asList(
+ REL_SUCCESS, REL_FAILURE
+ )));
+
+ private volatile SendTrapSNMPHandler snmpHandler;
+ private Instant startTime;
+
+ @Override
+ protected Collection<ValidationResult> customValidate(ValidationContext
context) {
+ List<ValidationResult> results = new ArrayList<>();
+
+ final boolean isPredefinedGenTrapType =
context.getProperty(V1TrapProperties.PREDEFINED_GENERIC_TRAP_TYPE).isSet();
+ final boolean isGenTrapType =
context.getProperty(V1TrapProperties.GENERIC_TRAP_TYPE).isSet();
+ final boolean isV1Trap = SnmpConstants.version1 ==
context.getProperty(BasicProperties.SNMP_VERSION).asInteger();
+
+ if (isV1Trap && isPredefinedGenTrapType && isGenTrapType) {
+ results.add(new ValidationResult.Builder()
+
.subject(V1TrapProperties.GENERIC_TRAP_TYPE.getDisplayName())
+ .explanation("Only one Generic Trap Type property can be
set.")
+ .valid(false)
+ .build());
+ } else if (isV1Trap && !isPredefinedGenTrapType && !isGenTrapType) {
+ results.add(new ValidationResult.Builder()
+
.subject(V1TrapProperties.GENERIC_TRAP_TYPE.getDisplayName())
+ .explanation("Generic Trap Type or Predefined Generic Trap
Type must be set.")
+ .valid(false)
+ .build());
+ }
+
+ return results;
+ }
+
+ @OnScheduled
+ public void init(ProcessContext context) {
+ startTime = Instant.now();
+ initSnmpManager(context);
+ }
+
+ @Override
+ public void onTrigger(final ProcessContext context, final ProcessSession
processSession) {
+ final FlowFile flowFile = processSession.get();
+ final int snmpVersion =
context.getProperty(BasicProperties.SNMP_VERSION).asInteger();
+ final Supplier<PDU> pduFactory;
+ if (SnmpConstants.version1 == snmpVersion) {
+ V1TrapConfiguration trapConfiguration =
V1TrapConfiguration.builder()
+
.enterpriseOid(context.getProperty(V1TrapProperties.ENTERPRISE_OID).evaluateAttributeExpressions(flowFile).getValue())
+
.agentAddress(context.getProperty(V1TrapProperties.AGENT_ADDRESS).evaluateAttributeExpressions(flowFile).getValue())
+ .genericTrapType(getGenericTrapType(context, flowFile))
+
.specificTrapType(context.getProperty(V1TrapProperties.SPECIFIC_TRAP_TYPE).asInteger())
+ .build();
+
+ pduFactory = new V1TrapPDUFactory(snmpResourceHandler.getTarget(),
trapConfiguration, startTime);
Review comment:
The factory should still be created in the init() and should be kept
context-independent.
The instead, the trap configuration (the creation of which should be kept
here as it is context-dependent) should be passed as a parameter to the
trap-creating method.
##########
File path:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/dto/SNMPSingleResponse.java
##########
@@ -65,4 +68,17 @@ public int getVersion() {
public boolean isReportPdu() {
return responsePdu.getType() == PDU.REPORT;
}
+
+ public boolean isOidProvidedByFlowFile() {
+ return !incomingFlowFileAttributes.isEmpty();
+ }
+
+ public Map<String, String> getOutgoingFlowFileAttributes() {
Review comment:
It's probably best not to filter out any of the incoming attributes.
That being said, the response shouldn't handle the incoming attributes
anyway. That responsibility is better left at the processor level.
##########
File path:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SendTrapSNMP.java
##########
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.snmp.processors;
+
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.snmp.configuration.V1TrapConfiguration;
+import org.apache.nifi.snmp.configuration.V2TrapConfiguration;
+import org.apache.nifi.snmp.factory.trap.V1TrapPDUFactory;
+import org.apache.nifi.snmp.factory.trap.V2TrapPDUFactory;
+import org.apache.nifi.snmp.operations.SendTrapSNMPHandler;
+import org.apache.nifi.snmp.processors.properties.BasicProperties;
+import org.apache.nifi.snmp.processors.properties.V1TrapProperties;
+import org.apache.nifi.snmp.processors.properties.V2TrapProperties;
+import org.apache.nifi.snmp.processors.properties.V3SecurityProperties;
+import org.snmp4j.PDU;
+import org.snmp4j.mp.SnmpConstants;
+
+import java.io.IOException;
+import java.time.Instant;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.function.Supplier;
+
+/**
+ * Sends data to an SNMP manager which, upon each invocation of
+ * {@link #onTrigger(ProcessContext, ProcessSession)} method, will construct a
+ * {@link FlowFile} containing in its properties the information retrieved.
+ * The output {@link FlowFile} won't have any content.
+ */
+@Tags({"snmp", "send", "trap"})
+@InputRequirement(Requirement.INPUT_ALLOWED)
+@CapabilityDescription("Sends information to SNMP Manager.")
+public class SendTrapSNMP extends AbstractSNMPProcessor {
+
+ public static final PropertyDescriptor SNMP_MANAGER_HOST = new
PropertyDescriptor.Builder()
+ .name("snmp-trap-manager-host")
+ .displayName("SNMP Manager Host")
+ .description("The host where the SNMP Manager sends the trap.")
+ .required(true)
+ .defaultValue("localhost")
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+ .build();
+
+ public static final PropertyDescriptor SNMP_MANAGER_PORT = new
PropertyDescriptor.Builder()
+ .name("snmp-trap-manager-port")
+ .displayName("SNMP Manager Port")
+ .description("The port where the SNMP Manager listens to the
incoming traps.")
+ .required(true)
+ .defaultValue("0")
+ .addValidator(StandardValidators.PORT_VALIDATOR)
+ .build();
+
+ public static final Relationship REL_SUCCESS = new Relationship.Builder()
+ .name("success")
+ .description("All FlowFiles that have been successfully used to
perform SNMP Set are routed to this relationship")
+ .build();
+
+ public static final Relationship REL_FAILURE = new Relationship.Builder()
+ .name("failure")
+ .description("All FlowFiles that cannot received from the SNMP
agent are routed to this relationship")
+ .build();
+
+ protected static final List<PropertyDescriptor> PROPERTY_DESCRIPTORS =
Collections.unmodifiableList(Arrays.asList(
+ SNMP_MANAGER_HOST,
+ SNMP_MANAGER_PORT,
+ BasicProperties.SNMP_VERSION,
+ BasicProperties.SNMP_COMMUNITY,
+ V3SecurityProperties.SNMP_SECURITY_LEVEL,
+ V3SecurityProperties.SNMP_SECURITY_NAME,
+ V3SecurityProperties.SNMP_AUTH_PROTOCOL,
+ V3SecurityProperties.SNMP_AUTH_PASSWORD,
+ V3SecurityProperties.SNMP_PRIVACY_PROTOCOL,
+ V3SecurityProperties.SNMP_PRIVACY_PASSWORD,
+ BasicProperties.SNMP_RETRIES,
+ BasicProperties.SNMP_TIMEOUT,
+ V1TrapProperties.ENTERPRISE_OID,
+ V1TrapProperties.AGENT_ADDRESS,
+ V1TrapProperties.PREDEFINED_GENERIC_TRAP_TYPE,
+ V1TrapProperties.GENERIC_TRAP_TYPE,
+ V1TrapProperties.SPECIFIC_TRAP_TYPE,
+ V2TrapProperties.TRAP_OID_VALUE
+ ));
+
+ private static final Set<Relationship> RELATIONSHIPS =
Collections.unmodifiableSet(new HashSet<>(Arrays.asList(
+ REL_SUCCESS, REL_FAILURE
+ )));
+
+ private volatile SendTrapSNMPHandler snmpHandler;
+ private Instant startTime;
+
+ @Override
+ protected Collection<ValidationResult> customValidate(ValidationContext
context) {
+ List<ValidationResult> results = new ArrayList<>();
+
+ final boolean isPredefinedGenTrapType =
context.getProperty(V1TrapProperties.PREDEFINED_GENERIC_TRAP_TYPE).isSet();
+ final boolean isGenTrapType =
context.getProperty(V1TrapProperties.GENERIC_TRAP_TYPE).isSet();
+ final boolean isV1Trap = SnmpConstants.version1 ==
context.getProperty(BasicProperties.SNMP_VERSION).asInteger();
+
+ if (isV1Trap && isPredefinedGenTrapType && isGenTrapType) {
+ results.add(new ValidationResult.Builder()
+
.subject(V1TrapProperties.GENERIC_TRAP_TYPE.getDisplayName())
+ .explanation("Only one Generic Trap Type property can be
set.")
+ .valid(false)
+ .build());
+ } else if (isV1Trap && !isPredefinedGenTrapType && !isGenTrapType) {
+ results.add(new ValidationResult.Builder()
+
.subject(V1TrapProperties.GENERIC_TRAP_TYPE.getDisplayName())
+ .explanation("Generic Trap Type or Predefined Generic Trap
Type must be set.")
+ .valid(false)
+ .build());
+ }
+
+ return results;
+ }
+
+ @OnScheduled
+ public void init(ProcessContext context) {
+ startTime = Instant.now();
+ initSnmpManager(context);
+ }
+
+ @Override
+ public void onTrigger(final ProcessContext context, final ProcessSession
processSession) {
+ final FlowFile flowFile = processSession.get();
+ final int snmpVersion =
context.getProperty(BasicProperties.SNMP_VERSION).asInteger();
+ final Supplier<PDU> pduFactory;
+ if (SnmpConstants.version1 == snmpVersion) {
+ V1TrapConfiguration trapConfiguration =
V1TrapConfiguration.builder()
+
.enterpriseOid(context.getProperty(V1TrapProperties.ENTERPRISE_OID).evaluateAttributeExpressions(flowFile).getValue())
+
.agentAddress(context.getProperty(V1TrapProperties.AGENT_ADDRESS).evaluateAttributeExpressions(flowFile).getValue())
+ .genericTrapType(getGenericTrapType(context, flowFile))
+
.specificTrapType(context.getProperty(V1TrapProperties.SPECIFIC_TRAP_TYPE).asInteger())
+ .build();
+
+ pduFactory = new V1TrapPDUFactory(snmpResourceHandler.getTarget(),
trapConfiguration, startTime);
Review comment:
The factory should still be created in the init() and should be kept
context-independent (and thread safe).
Instead, the trap configuration (the creation of which should be kept here
as it is context-dependent) should be passed as a parameter to the
trap-creating method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
