[
https://issues.apache.org/jira/browse/NIFI-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440467#comment-17440467
]
ASF subversion and git services commented on NIFI-9366:
-------------------------------------------------------
Commit f86fe0d61ae0310a191e14f7521ef9e3e4d0727c in nifi's branch
refs/heads/main from Chris Sampson
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f86fe0d ]
NIFI-9366 Create and remove provenance repository directory in test methods
- Updated nifi-persistent-provenance-repository tests
This closes #5510
Signed-off-by: David Handermann <[email protected]>
> nifi-persistent-provenance-repository tests create unwanted
> provenance_repository directory in filesystem
> ---------------------------------------------------------------------------------------------------------
>
> Key: NIFI-9366
> URL: https://issues.apache.org/jira/browse/NIFI-9366
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.15.0
> Reporter: Chris Sampson
> Assignee: Chris Sampson
> Priority: Trivial
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Executing the tests within the {{nifi-persistent-provenance-repository}}
> results in an unwanted directory being created in the filesystem that could
> accidentally be committed to git:
> *
> {{nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/provenance_repository/}}
> This is caused by the Groovy-based test
> {{EncryptedWriteAheadProvenanceRepositoryTest#testShouldRegisterAndGetEvents}},
> which doesn't override the default {{nifi.properties}} value for
> {{nifi.provenance.repository.directory.}} of {{provenance_repository}} - this
> results in the directory being created as indicated above. It would be better
> to locate the directory either in {{target/}} (therefore ignored by default
> in Git commits as part of the Maven build) or a Temp directory as done in
> {{#testWriteAheadProvenanceRepositoryShouldRegisterAndRetrieveEvents}} within
> the same Test class.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
