adam-markovics commented on a change in pull request #1107:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1107#discussion_r746475581
##########
File path:
libminifi/include/controllers/keyvalue/AbstractCoreComponentStateManagerProvider.h
##########
@@ -66,8 +76,11 @@ class AbstractCoreComponentStateManagerProvider : public
std::enable_shared_from
virtual bool removeImpl(const utils::Identifier& key) = 0;
virtual bool persistImpl() = 0;
- virtual std::string serialize(const core::CoreComponentState& kvs);
- bool deserialize(const std::string& serialized, core::CoreComponentState&
kvs);
+ private:
+ void removeFromCache(utils::Identifier id);
+
+ std::mutex mutex;
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]