fgerlits commented on a change in pull request #1211:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1211#discussion_r749462278
##########
File path: libminifi/src/utils/file/FileUtils.cpp
##########
@@ -48,6 +48,44 @@ uint64_t computeChecksum(const std::string &file_name,
uint64_t up_to_position)
return checksum;
}
+bool contains(const std::filesystem::path& file_path, std::string_view string)
{
Review comment:
`string` is not a great parameter name; something like `target` or
`thing_to_look_for` would be better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
