szaszm commented on a change in pull request #1212:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1212#discussion_r751139001
##########
File path: extensions/librdkafka/PublishKafka.h
##########
@@ -89,8 +84,19 @@ class PublishKafka : public core::Processor {
EXTENSIONAPI static const core::Relationship Failure;
EXTENSIONAPI static const core::Relationship Success;
+ static const std::string COMPRESSION_CODEC_NONE;
+ static const std::string COMPRESSION_CODEC_GZIP;
+ static const std::string COMPRESSION_CODEC_SNAPPY;
+ static const std::string ROUND_ROBIN_PARTITIONING;
+ static const std::string RANDOM_PARTITIONING;
+ static const std::string USER_DEFINED_PARTITIONING;
+ static const std::string DELIVERY_REPLICATED;
+ static const std::string DELIVERY_ONE_NODE;
+ static const std::string DELIVERY_BEST_EFFORT;
+ static const std::string KAFKA_KEY_ATTRIBUTE;
Review comment:
`constexpr` implies implicit top-level `const`, so `constexpr const
char* const` is the same as `constexpr const char*`. I prefer the last const to
be removed, but this is just nitpicking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
