sedadgn commented on a change in pull request #5458:
URL: https://github.com/apache/nifi/pull/5458#discussion_r757455310
##########
File path: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/pom.xml
##########
@@ -21,6 +21,8 @@ language governing permissions and limitations under the
License. -->
<properties>
<amqp-client.version>5.8.0</amqp-client.version>
+ <common-text.version>1.8</common-text.version>
Review comment:
> Hey @sedadgn! Thank you for implementing the alternative approach.
I've found few things, can you check them? None of them is a big thing so I
also think we are really close to merging. One slight thing. There are a lot of
inconsistently placed empty lines, missing spaces. They are not considered
blocker issues in the community but can I ask you to clean them? I'd appreciate
if you could do.
@nandorsoma
Thank you for your review. I wrote few comment. I made few changing
according your comment.
Best Regards
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
