adamdebreceni commented on a change in pull request #1218:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1218#discussion_r760132619
##########
File path: cmake/BuildTests.cmake
##########
@@ -101,6 +101,7 @@ target_include_directories(${CATCH_MAIN_LIB} SYSTEM BEFORE
PRIVATE "${CMAKE_SOUR
SET(TEST_RESOURCES ${TEST_DIR}/resources)
GETSOURCEFILES(UNIT_TESTS "${TEST_DIR}/unit/")
+GETSOURCEFILES(TLS_UNIT_TESTS "${TEST_DIR}/unit/tls/")
Review comment:
I wanted to do that first but this test needs access to the test
resources which other tests get through command line arguments, moreover to
access said resource path we need to have our own main, which conflicts with
linking to `CATCH_MAIN_LIB`, moreover these tests use relative source file
names (`add_executable("${testfilename}" "${TEST_DIR}/unit/${testfile}")`) but
`GETSOURCEFILES` do not expose to what path we would like to have the relative
path (`FILE(GLOB children RELATIVE ${curdir} ${curdir}/*)`) so we would need to
either expose that or use `file(GLOB ...)` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
