ChrisSamo632 commented on a change in pull request #5504:
URL: https://github.com/apache/nifi/pull/5504#discussion_r762612066
##########
File path:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/wag/AbstractAWSGatewayApiProcessor.java
##########
@@ -467,23 +469,22 @@ protected InputStream getRequestBodyToSend(final
ProcessSession session,
protected GenericApiGatewayRequestBuilder setHeaderProperties(final
ProcessContext context,
GenericApiGatewayRequestBuilder requestBuilder,
-
HttpMethodName methodName,
- final
FlowFile requestFlowFile) {
+ final
HttpMethodName methodName,
+ final
Map<String, String> requestAttributes) {
- Map<String, String> headers = new HashMap<>();
- for (String headerKey : dynamicPropertyNames) {
+ final Map<String, String> headers = new HashMap<>();
+ for (final String headerKey : dynamicPropertyNames) {
String headerValue = context.getProperty(headerKey)
Review comment:
But then maybe we don't want to go through and make everything `final`
in all of these classes at this point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
