ChrisSamo632 commented on a change in pull request #5504:
URL: https://github.com/apache/nifi/pull/5504#discussion_r763171291
##########
File path:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/wag/InvokeAWSGatewayApi.java
##########
@@ -380,4 +355,87 @@ public void onTrigger(ProcessContext context,
ProcessSession session) throws Pro
}
}
}
+
+ @Override
+ public List<ConfigVerificationResult> verify(final ProcessContext context,
final ComponentLog verificationLogger, final Map<String, String> attributes) {
+ final List<ConfigVerificationResult> results = new
ArrayList<>(super.verify(context, verificationLogger, attributes));
+
+ final String method = context.getProperty(PROP_METHOD).getValue();
+ final String endpoint =
context.getProperty(PROP_AWS_GATEWAY_API_ENDPOINT).getValue();
+ final String resource =
context.getProperty(PROP_RESOURCE_NAME).getValue();
+ try {
+ final GenericApiGatewayClient client =
getConfiguration(context).getClient();
+
+ final GatewayResponse gatewayResponse = invokeGateway(client,
context, null, null, attributes, verificationLogger);
Review comment:
Happy that this isn't an issue any longer (see
https://github.com/apache/nifi/pull/5504#discussion_r763169549) - the change to
have the Idempotent methods list was definitely worthwhile I think and I'm
happy that the triggering of this check will be at the behest of the user
that's configuring the processor (and so they should know whether their service
can be "pinged" in this manner)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
