simonbence commented on pull request #5530:
URL: https://github.com/apache/nifi/pull/5530#issuecomment-987258188


   > I gave this a try (I didn't look at the code though) and this is a really 
nice improvement! I'd recommend updating this PR to also include the changes 
added in #5555. Once done, I'll run more tests with some data I have on my 
systems.
   
   Thank you very much for bringing this to my attention, this is a valuabe 
addition indeed! I encorporated this to the reader's functionality. Let me also 
highlight two smaller details:
   - With "standard extensions" the behaviour of the scema inference might be 
unexpected but this is because of the reader mimics the extension dictionary
   - In case of String typed extensions the parser looks to be works somewhat 
different. I added tests regarding and I hope you do not mind that I extended 
your test with this discovery as well.
   
   Again, thank you for your invested time!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to