[
https://issues.apache.org/jira/browse/NIFI-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612942#comment-15612942
]
ASF GitHub Bot commented on NIFI-2954:
--------------------------------------
GitHub user apiri opened a pull request:
https://github.com/apache/nifi/pull/1164
NIFI-2954 - Treating bcprov and bcpkix dependencies as provided by nifi in
lib
NIFI-2954 - Treating bcprov and bcpkix dependencies as provided by nifi in
lib and updating projects to include them as provided where needed.
Not sure of the best direction to take this, but the general thought
process were to treat bcprov and bcpkix as "framework level" dependencies and
include them in lib. This allowed these common, foundational libraries to be
shared by the entirety of the extension space.
I am not a fan of having to add these every place the BC items are
transitively used but did not also want to make a specified dependency in a
parent pom across the entirety of the project.
Before patch:
```
drwxr-xr-x 3 apiri staff 102 Oct 27 15:08 nifi-1.1.0-SNAPSHOT-bin
-rw-r--r-- 1 apiri staff 608M Oct 27 15:09 nifi-1.1.0-SNAPSHOT-bin.tar.gz
-rw-r--r-- 1 apiri staff 608M Oct 27 15:08 nifi-1.1.0-SNAPSHOT-bin.zip
```
After patch:
```
drwxr-xr-x 3 apiri staff 102 Oct 27 15:17 nifi-1.1.0-SNAPSHOT-bin
-rw-r--r-- 1 apiri staff 778M Oct 27 15:18 nifi-1.1.0-SNAPSHOT-bin.tar.gz
-rw-r--r-- 1 apiri staff 779M Oct 27 15:18 nifi-1.1.0-SNAPSHOT-bin.zip
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apiri/incubator-nifi nifi-2954
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1164.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1164
----
commit bc4b358b477df0cc113b14af02b5f89d0b1b38e5
Author: Aldrin Piri <[email protected]>
Date: 2016-10-27T19:12:39Z
NIFI-2954 - Treating bcprov and bcpkix dependencies as provided by nifi in
lib and updating projects to include them as provided where needed.
----
> Bouncycastle dependencies are duplicated throughout NARs
> --------------------------------------------------------
>
> Key: NIFI-2954
> URL: https://issues.apache.org/jira/browse/NIFI-2954
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
> Affects Versions: 1.0.0
> Reporter: Aldrin Piri
> Assignee: Aldrin Piri
>
> I was working with some of the NiFi dependencies for incorporation with/use
> by MiNiFi and saw that several libraries were duplicated throughout all NARs.
> Of note were the bouncycastle dependencies which, together, are ~4MB in size.
> {code}
> # apiri @ computer in /usr/local/opt/nifi/libexec [17:20:23]
> $ find {lib,work} -type f -name '*bcprov-jdk15on*' | wc -l
> 54
> # apiri @ computer in /usr/local/opt/nifi/libexec [17:20:28]
> $ find {lib,work} -type f -name '*bcpkix*' | wc -l
> 53
> # apiri @ computer in /usr/local/opt/nifi/libexec [17:20:33]
> $ ls -lash
> work/nar/framework/nifi-framework-nar-1.0.0.nar-unpacked/META-INF/bundled-dependencies/bcprov-jdk15on-1.54.jar
> 3.2M -rw-r--r-- 1 apiri admin 3.2M Oct 4 12:24
> work/nar/framework/nifi-framework-nar-1.0.0.nar-unpacked/META-INF/bundled-dependencies/bcprov-jdk15on-1.54.jar
> # apiri @ computer in /usr/local/opt/nifi/libexec [17:20:39]
> $ ls -lash
> work/nar/framework/nifi-framework-nar-1.0.0.nar-unpacked/META-INF/bundled-dependencies/bcpkix-jdk15on-1.54.jar
> 660K -rw-r--r-- 1 apiri admin 658K Oct 4 12:24
> work/nar/framework/nifi-framework-nar-1.0.0.nar-unpacked/META-INF/bundled-dependencies/bcpkix-jdk15on-1.54.jar
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
