martinzink commented on a change in pull request #1225:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1225#discussion_r769566006
##########
File path: libminifi/src/provenance/Provenance.cpp
##########
@@ -45,13 +45,13 @@ const char
*ProvenanceEventRecord::ProvenanceEventTypeStr[REPLAY + 1] = { "CREAT
ProvenanceEventRecord::ProvenanceEventRecord(ProvenanceEventRecord::ProvenanceEventType
event, std::string componentId, std::string componentType)
: core::SerializableComponent(core::getClassName<ProvenanceEventRecord>()),
- _entryDate(0),
- _lineageStartDate(0),
+ _entryDate(std::chrono::time_point<std::chrono::system_clock>()),
Review comment:
Removed these and other unneccesary initializations from the ctors in
https://github.com/apache/nifi-minifi-cpp/pull/1225/commits/78f8658fde802c73a5965dd734a544acbc37dca3
I prefer the `std::chrono::system_clock::time_point` aswell, its more
readable thanks for idea @adamdebreceni, changed all references of
time_point<x_clock> to x_clock::time_point in
https://github.com/apache/nifi-minifi-cpp/pull/1225/commits/78f8658fde802c73a5965dd734a544acbc37dca3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
