[ 
https://issues.apache.org/jira/browse/NIFI-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613228#comment-15613228
 ] 

ASF GitHub Bot commented on NIFI-2115:
--------------------------------------

Github user mcgilman commented on the issue:

    https://github.com/apache/nifi/pull/583
  
    Hey @jvwing... I had a chance to check out the update. Everything looks 
good but I do have one other comment that I probably should have noticed 
before. Given the build details ultimately come from `nifi.properties` I don't 
think we can rely on their presence. Often times, folks upgrade by retaining 
their consisting `conf` directory so we typically try to ensure things still 
work when the properties do not exist. In the System Diagnostics, it probably 
makes sense to simply populate the fields with a message indicating that the 
value isn't set. Additionally, you can style the elements with `unset`. In the 
About dialog is probably makes sense to just not render anything under the 
version. Currently, it just says 'Tagged'.
    
    Thoughts?



> Enhanced About Box Version Information
> --------------------------------------
>
>                 Key: NIFI-2115
>                 URL: https://issues.apache.org/jira/browse/NIFI-2115
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core UI, Tools and Build
>    Affects Versions: 1.0.0
>            Reporter: James Wing
>            Assignee: James Wing
>            Priority: Minor
>         Attachments: screenshot-1-of-4-about-expands.png, 
> screenshot-2-of-4-git-build.png, screenshot-3-of-4-release-build.png, 
> screenshot-4-of-4-source-build.png
>
>
> The UI's About dialog and underlying API provide the version of NiFi, like 
> "0.7.0-SNAPSHOT".  For many bug reports and troubleshooting requests, this is 
> not very precise, especially around rapidly changing code or 
> platform-dependent behavior.  It would help if NiFi captured and displayed 
> additional information:  
> * NiFi build commit hash
> * NiFi build branch
> * NiFi build date/time
> * Java Version
> * Java Vendor (Oracle, OpenJDK)
> * OS
> Then a simple copy/paste from the about box would provide very specific 
> information about a particular NiFi installation and which code it was 
> derived from.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to