szaszm commented on a change in pull request #1228:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1228#discussion_r773852660
##########
File path: extensions/script/python/PythonScriptEngine.h
##########
@@ -57,7 +57,7 @@ struct Interpreter {
Interpreter *getInterpreter();
-class PythonScriptEngine : public script::ScriptEngine {
+class __attribute__((visibility("default"))) PythonScriptEngine : public
script::ScriptEngine {
Review comment:
It looks like we are not testing this extension on msvc. I'm fine with
ignoring the error until we actually want to support this on windows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
