adam-markovics commented on a change in pull request #1232:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1232#discussion_r778717351
##########
File path: extensions/script/ExecuteScript.cpp
##########
@@ -52,6 +52,28 @@ core::Property ExecuteScript::ModuleDirectory("Module
Directory", // NOLINT
core::Relationship ExecuteScript::Success("success", "Script successes"); //
NOLINT
core::Relationship ExecuteScript::Failure("failure", "Script failures"); //
NOLINT
+ScriptEngineFactory::ScriptEngineFactory(core::Relationship& success,
core::Relationship& failure, std::shared_ptr<core::logging::Logger> logger)
+ : success_(success),
+ failure_(failure),
+ logger_(logger) {
+}
+
+ScriptEngineQueue::ScriptEngineQueue(uint8_t max_engine_count,
ScriptEngineFactory& engine_factory, std::shared_ptr<core::logging::Logger>
logger)
+ : max_engine_count_(max_engine_count),
+ engine_factory_(engine_factory),
+ logger_(logger) {
+}
+
+void
ScriptEngineQueue::returnScriptEngine(std::shared_ptr<script::ScriptEngine>&&
engine) {
+ const std::lock_guard<std::mutex> lock(queue_mutex_);
+ if (engine_queue_.size_approx() < max_engine_count_) {
+ logger_->log_debug("Releasing [%p] script engine", engine.get());
+ engine_queue_.enqueue(engine);
Review comment:
std::move could be used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
