[
https://issues.apache.org/jira/browse/NIFI-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470202#comment-17470202
]
ASF subversion and git services commented on NIFI-9546:
-------------------------------------------------------
Commit 56593ad12f40bbacd4627436eadc38a24f58ee16 in nifi's branch
refs/heads/main from Mark Payne
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=56593ad ]
NIFI-9546: Updated PutTCP and PutUDP with SupportsBatching annotations
- Removed incorrect usage of TriggerWhenEmpty
- Allow for 0 seconds of gracefully waiting for incoming threads on shutdown
since we won't have any
- Updated unit tests to no longer have arbitrary sleep statements
This closes #5639
Signed-off-by: David Handermann <[email protected]>
> PutTCP / PutUDP are inefficient
> -------------------------------
>
> Key: NIFI-9546
> URL: https://issues.apache.org/jira/browse/NIFI-9546
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Major
> Fix For: 1.16.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The PutTCP and PutUDP processors do not use the {{@SupportsBatching}}
> annotation, which can make a huge different in performance. Additionally,
> they both are annotated with {{@TriggerWhenEmpty}} but then do nothing when
> they have no incoming FlowFiles, which wastes a lot of resources. And the
> shutdown routine waits 2 seconds to shutdown the processor "gracefully"
> meaning it'll wait for any additional threads that come in to complete.
> However we know that there will be no additional threads, so we should stop
> waiting those 2 seconds - this slows down the unit tests significantly, also.
> Unit tests also have a lot of seemingly arbitrary sleep() statements that
> don't appear to have any value.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
