[ 
https://issues.apache.org/jira/browse/NIFI-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15618679#comment-15618679
 ] 

ASF GitHub Bot commented on NIFI-2834:
--------------------------------------

Github user josephxsxn commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1167#discussion_r85647660
  
    --- Diff: 
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/eventhub/GetAzureEventHub.java
 ---
    @@ -264,6 +285,16 @@ public void onScheduled(final ProcessContext context) 
throws ProcessException {
             } else {
                 configuredEnqueueTime = null;
             }
    +        if(context.getProperty(RECEIVER_FETCH_SIZE).isSet()) {
    +            receiverFetchSize = 
context.getProperty(RECEIVER_FETCH_SIZE).asInteger();
    +        } else {
    +            receiverFetchSize = 100;
    +        }
    +        if(context.getProperty(RECEIVER_FETCH_TIMEOUT).isSet()) {
    +            receiverFetchTimeout = 
Duration.ofSeconds(context.getProperty(RECEIVER_FETCH_TIMEOUT).asLong());
    --- End diff --
    
    This should be ofMils not ofSeconds


> GetAzureEventHub should be more configurable
> --------------------------------------------
>
>                 Key: NIFI-2834
>                 URL: https://issues.apache.org/jira/browse/NIFI-2834
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Joseph Percivall
>            Assignee: Joseph Niemiec
>            Priority: Minor
>             Fix For: 1.1.0
>
>
> Current GetAzureEventHub processor is configured to always grab a max batch 
> of 100 events per ontrigger[1]. This internal batching scheme should be made 
> configurable.
> Also there is an internal default timeout set for PartitionReceivers of 60 
> seconds. This means each time the processor is triggered it will be blocked 
> waiting for there to be the max number of events (currently 100) before 
> canceling 60s later if there isn't 100 events. This should be configurable.
> [1] 
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/eventhub/GetAzureEventHub.java#L215



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to