fgerlits commented on a change in pull request #1196:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1196#discussion_r779707518
##########
File path: docker/test/integration/minifi/processors/DeleteAzureBlobStorage.py
##########
@@ -0,0 +1,14 @@
+from ..core.Processor import Processor
+
+
+class DeleteAzureBlobStorage(Processor):
+ def __init__(self):
Review comment:
This could be event driven by default like other `INPUT_REQUIRED`
processors, eg. `HashContent`.
##########
File path: docker/test/integration/minifi/core/DockerTestCluster.py
##########
@@ -8,9 +8,15 @@
from .SingleNodeDockerCluster import SingleNodeDockerCluster
from .utils import retry_check
+from azure.storage.blob import BlobServiceClient
+from azure.core.exceptions import ResourceExistsError
class DockerTestCluster(SingleNodeDockerCluster):
+ AZURE_CONNECTION_STRING = \
+
("DefaultEndpointsProtocol=http;AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;"
+
"BlobEndpoint=http://127.0.0.1:10000/devstoreaccount1;QueueEndpoint=http://127.0.0.1:10001/devstoreaccount1;";)
Review comment:
You have added this connection string twice, and it is already present
in `PutAzureBlobStorage.py`; it would be better to define it once and use that
definition in these three places.
##########
File path: PROCESSORS.md
##########
@@ -328,6 +329,35 @@ In the list below, the names of required properties appear
in bold. Any other pr
|success|Flowfiles that have been successfully defragmented|
|failure|Flowfiles that failed the defragmentation process|
+## DeleteAzureBlobStorage
+
+### Description
+
+Deletes the provided blob from Azure Storage
+### Properties
+
+In the list below, the names of required properties appear in bold. Any other
properties (not in bold) are considered optional. The table also indicates any
default values, and whether a property supports the NiFi Expression Language.
+
+| Name | Default Value | Allowable Values | Description |
+| - | - | - | - |
+|Azure Storage Credentials Service|||Name of the Azure Storage Credentials
Service used to retrieve the connection string from.|
+|**Blob**|||The filename of the blob. If left empty the filename attribute
will be used by default.<br/>**Supports Expression Language: true**|
+|Common Storage Account Endpoint Suffix|||Storage accounts in public Azure
always use a common FQDN suffix. Override this endpoint suffix with a different
suffix in certain circumstances (like Azure Stack or non-public Azure
regions).<br/>**Supports Expression Language: true**|
+|Connection String|||Connection string used to connect to Azure Storage
service. This overrides all other set credential properties if Managed Identity
is not used.<br/>**Supports Expression Language: true**|
+|**Container Name**|||Name of the Azure storage container. In case of
PutAzureBlobStorage processor, container can be created if it does not
exist.<br/>**Supports Expression Language: true**|
+|**Delete Snapshots Option**|None|None<br/>Include Snapshots<br/>Delete
Snapshots Only|Specifies the snapshot deletion options to be used when deleting
a blob.<br/>None: Deletes the blob only.<br/>Include Snapshots: Delete the blob
and its snapshots.<br/>Delete Snapshots Only: Delete only the blob's snapshots.|
Review comment:
I think the names `blob only`, `blob and snapshots`, `snapshots only`
would be clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
