szaszm commented on a change in pull request #1232:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1232#discussion_r781663088
##########
File path: extensions/script/tests/CMakeLists.txt
##########
@@ -30,6 +30,7 @@ endif()
if (ENABLE_LUA_SCRIPTING)
file(GLOB EXECUTESCRIPT_LUA_TESTS
"TestExecuteScriptProcessorWithLuaScript.cpp" "LuaScriptEngineTests.cpp")
+ include_directories(${LUA_INCLUDE_DIR})
Review comment:
Don't use `include_directories`, because it's directory-based and
global. Specify them for the appropriate targets instead, with
`target_include_directories`. You may want to specify this one as PUBLIC on the
sol2 or the minifi-script-extensions target.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
