exceptionfactory commented on pull request #4863: URL: https://github.com/apache/nifi/pull/4863#issuecomment-1009491307
The concept of supporting integration with Azure KeyVault is great, but the implementation in this PR raises some questions. The ideal implementation would support Azure KeyVault at a lower level, as opposed to an explicit Controller Service, but perhaps this approach might be a reasonable intermediate solution. That being said, it would be helpful to narrow the scope of this PR to the Azure KeyVault service and implementation itself, and then look at integrating the service in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
