exceptionfactory commented on pull request #5571: URL: https://github.com/apache/nifi/pull/5571#issuecomment-1010309784
@timeabarna I rebased and add a new commit that refactors the sample filtering approach to use a logical OR when processing both the sampleName and sampleLabelValue parameters. I noticed that PR 5582 required both of those parameters to be specified, whereas this PR allows either one or both to be provided. With the most recent change, the Sample will only be removed when it matches neither the sampleName nor the sampleLabelValue pattern. Describing it in positive terms, the Sample will be included if it matches either the sampleName or the sampleLabelValue pattern. I added an additional unit test for this scenario. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
