markobean commented on a change in pull request #5324:
URL: https://github.com/apache/nifi/pull/5324#discussion_r786719842



##########
File path: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateXml.java
##########
@@ -64,26 +72,40 @@
     @WritesAttribute(attribute = "validatexml.invalid.error", description = 
"If the flow file is routed to the invalid relationship "
             + "the attribute will contain the error message resulting from the 
validation failure.")
 })
-@CapabilityDescription("Validates the contents of FlowFiles against a 
user-specified XML Schema file")
+@CapabilityDescription("Validates XML contained in a FlowFile. By default, the 
XML is contained in the FlowFile content. If the 'XML Source Attribute' 
property is set, the XML to be validated "
+        + "is contained in the specified attribute. It is not recommended to 
use attributes to hold large XML documents; doing so could adversely affect 
system performance. "
+        + "Full schema validation is performed if the processor is configured 
with the XSD schema details. Otherwise, the only validation performed is "
+        + "to ensure the XML syntax is correct and well-formed, e.g. all 
opening tags are properly closed.")
+@SystemResourceConsideration(resource = SystemResource.MEMORY, description = 
"While this processor supports processing XML within attributes, it is strongly 
discouraged to hold "

Review comment:
       To help address the possible memory concern for large XML in an 
attribute, the `@SystemResourceConsideration` annotation was added to the 
documentation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to