[
https://issues.apache.org/jira/browse/NIFI-2603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625965#comment-15625965
]
ASF GitHub Bot commented on NIFI-2603:
--------------------------------------
GitHub user scottyaslan opened a pull request:
https://github.com/apache/nifi/pull/1171
[NIFI-2603] applying color to highlight status changes
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scottyaslan/nifi NIFI-2603
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1171.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1171
----
commit 23fe6ff7027f1760f790e43bfee59fa562a28041
Author: Peter Wicks <[email protected]>
Date: 2016-08-22T17:45:20Z
NIFI-2603
commit b55d8a5032ed9a14b2b6a2cc62003ab55806e44d
Author: Peter Wicks <[email protected]>
Date: 2016-08-23T17:47:46Z
Gui Icons
commit d1df2bfaccdc0040a8e8c1f68754da870ca38df4
Author: Peter Wicks <[email protected]>
Date: 2016-08-24T16:01:37Z
Gui Icons - Fixing Orange Color
commit 20e6d060767c844b0ee177326cc96ae8e8119531
Author: Peter Wicks <[email protected]>
Date: 2016-08-24T21:45:54Z
Gui Icons - Fixing misc. colors
commit 768276cf9c809fe4290dfdb7a89bc6fcab8f97e0
Author: Peter Wicks <[email protected]>
Date: 2016-08-24T23:38:10Z
Gui Icons - Summary page + spinner
commit 3f32bf5cd28361c1d8c4c7f011b16d6c13b98402
Author: Peter Wicks <[email protected]>
Date: 2016-08-25T01:15:02Z
Gui Icons - Summary page again
commit f60695b3efe6c23f9a966f3068dd79ec4ed699f5
Author: Scott Aslan <[email protected]>
Date: 2016-11-01T15:29:07Z
[NIFI-2603] applying color to highlight status changes
----
> Bringing Some UI Color Back
> ---------------------------
>
> Key: NIFI-2603
> URL: https://issues.apache.org/jira/browse/NIFI-2603
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core UI
> Reporter: Peter Wicks
> Assignee: Scott Aslan
> Priority: Minor
> Fix For: 1.1.0
>
> Attachments: running-disabled-adjustment.png,
> settings-shell-controller-services.png, settings-shell-reporting-tasks.png,
> status-bars-and-components.png, summary-shell.png
>
>
> In the new 1.0 UI all of the colors associated with status (except the orange
> triangle) are gone; replaced with a dark gray color.
> I propose bringing back color. The screenshots are in the format of before
> on the top and after on the bottom, except were labeled in the picture itself:
> - Top Status Menu: https://goo.gl/photos/se1JnvhRwU7N4Fap7
> - Process Group: https://goo.gl/photos/dqjG4KvC6xqxQfgT7
> - Processes (Running/Stopped/Invalid):
> https://goo.gl/photos/dSS8vgE2RkrXtc77A
> - Operate Play/Stop buttons (only on mouse hover):
> https://goo.gl/photos/Am5SUEEn7G9RjmMe6
> - Processor/Processor Group Context Menu:
> https://goo.gl/photos/Jq3qFg4ezaN91qms5
> This is not a "100% done, I've covered everything" before/after list. I know
> I need to do the NiFi summary page also at the minimum.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
