szaszm commented on a change in pull request #1242: URL: https://github.com/apache/nifi-minifi-cpp/pull/1242#discussion_r790785027
########## File path: libminifi/include/utils/ListingStateManager.h ########## @@ -0,0 +1,71 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#include <string> +#include <unordered_map> +#include <unordered_set> +#include <memory> +#include <chrono> +#include <utility> + +#include "core/CoreComponentState.h" +#include "core/logging/Logger.h" +#include "core/logging/LoggerConfiguration.h" + +namespace org::apache::nifi::minifi::utils { + +class ListedObject { + public: + [[nodiscard]] virtual std::chrono::time_point<std::chrono::system_clock> getLastModified() const = 0; + [[nodiscard]] virtual std::string getKey() const = 0; + virtual ~ListedObject() = default; +}; + +struct ListingState { + bool wasObjectListedAlready(const ListedObject &object_attributes) const; Review comment: This could be nodiscard, too. ########## File path: libminifi/include/utils/GeneralUtils.h ########## @@ -111,10 +106,6 @@ template<typename T> using remove_cvref_t = typename std::remove_cv<typename std::remove_reference<T>::type>::type; #endif -} // namespace utils -} // namespace minifi -} // namespace nifi -} // namespace apache -} // namespace org +bool implies(bool a, bool b) noexcept; Review comment: This is trivial enough to keep it inline IMO. And maybe even `constexpr`. ```suggestion inline constexpr bool implies(bool a, bool b) noexcept { return !a || b; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
