kevdoran commented on pull request #5684: URL: https://github.com/apache/nifi/pull/5684#issuecomment-1021406693
Hi @guimou @dmnewber, This is a nice contribution and good discussion. I agree with you @guimou that there are real benefits to making NiFi images easier to deploy directly on OpenShift. I also agree with @dmnewber that it would be best not to duplicate the entire directory of files. While it may leave things more decoupled, it does increase the maintenance burden, as any any improvements to the default NiFi image would not also have to be done in more places (as we would probably want those same enhancements everywhere). We already have this problem today across docker hub and dockermaven variants, and plan to try to combine those so that they only differ one way, which is how the assembly artifacts are provided. I've started collecting ideas for how to improve our project structure for Docker images produced from the NiFi repository here, and I've added some of the goals of this PR to that list: https://cwiki.apache.org/confluence/display/NIFI/NiFi+Docker+Container+Improvements If this is not urgent, I would suggest we tackle some of those goals, such as image build consolidation and then figure out how to incorporate base image variants as part of that, to take another look at this. I haven't looked at the PR closely yet, but aside from basing on ubi8/OpenJDK11, are there any other significant changes from the current NiFi Dockerfile? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
