nrnalamalpu commented on a change in pull request #5291:
URL: https://github.com/apache/nifi/pull/5291#discussion_r796857393
##########
File path:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-2-6-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/KafkaProcessorUtils.java
##########
@@ -183,6 +186,35 @@
.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
.build();
+ static final PropertyDescriptor AWS_PROFILE_NAME = new
PropertyDescriptor.Builder()
Review comment:
@pvillard31 This is a really good observation. But, we don't need to add
these properties to each of the classes like ConsumeKafka 2.6,
ConsumeKafkaRecord 2.6, PublishKafka 2.6 and PublishKafkaRecord 2.6 if we
define them as public static variables.
**KafkaProcessorUtils.buildCommonKafkaProperties()** gets called from all
the above classes which adds all these public static properties to these
processors.
Call Stack from Consume/publishKafka classes:
KafkaProcessorUtils.buildCommonKafkaProperties() -->
isStaticStringFieldNamePresent() -->
KafkaProcessorUtils.getPublicStaticStringFieldValues()
I tested this within our NIFI cluster and I'll try to attach the screenshot
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
