greyp9 commented on pull request #5694: URL: https://github.com/apache/nifi/pull/5694#issuecomment-1027483745
The extra XML in the module descriptors seems to make sense, but after running a set of builds, it looks like we're not getting the right output. ``` nifi % mvn clean install -DskipTests ... nifi % find . -name "*bin.zip" ./nifi-assembly/target/nifi-1.16.0-SNAPSHOT-bin.zip ./nifi-toolkit/nifi-toolkit-assembly/target/nifi-toolkit-1.16.0-SNAPSHOT-bin.zip ./minifi/minifi-c2/minifi-c2-assembly/target/minifi-c2-1.16.0-SNAPSHOT-bin.zip ./minifi/minifi-toolkit/minifi-toolkit-assembly/target/minifi-toolkit-1.16.0-SNAPSHOT-bin.zip ./minifi/minifi-assembly/target/minifi-1.16.0-SNAPSHOT-bin.zip ./nifi-registry/nifi-registry-toolkit/nifi-registry-toolkit-assembly/target/nifi-registry-toolkit-1.16.0-SNAPSHOT-bin.zip ./nifi-registry/nifi-registry-extensions/nifi-registry-aws/nifi-registry-aws-assembly/target/nifi-registry-aws-assembly-1.16.0-SNAPSHOT-bin.zip ./nifi-registry/nifi-registry-extensions/nifi-registry-ranger/nifi-registry-ranger-assembly/target/nifi-registry-ranger-assembly-1.16.0-SNAPSHOT-bin.zip ./nifi-registry/nifi-registry-assembly/target/nifi-registry-1.16.0-SNAPSHOT-bin.zip ./nifi-stateless/nifi-stateless-assembly/target/nifi-stateless-1.16.0-SNAPSHOT-bin.zip nifi % find . -name "*bin.tar.gz" nifi % nifi % mvn clean install -DskipTests -P targz ... nifi % find . -name "*bin.zip" ./nifi-registry/nifi-registry-extensions/nifi-registry-aws/nifi-registry-aws-assembly/target/nifi-registry-aws-assembly-1.16.0-SNAPSHOT-bin.zip ./nifi-registry/nifi-registry-extensions/nifi-registry-ranger/nifi-registry-ranger-assembly/target/nifi-registry-ranger-assembly-1.16.0-SNAPSHOT-bin.zip nifi % find . -name "*bin.tar.gz" ./nifi-assembly/target/nifi-1.16.0-SNAPSHOT-bin.tar.gz ./nifi-toolkit/nifi-toolkit-assembly/target/nifi-toolkit-1.16.0-SNAPSHOT-bin.tar.gz ./minifi/minifi-c2/minifi-c2-assembly/target/minifi-c2-1.16.0-SNAPSHOT-bin.tar.gz ./minifi/minifi-toolkit/minifi-toolkit-assembly/target/minifi-toolkit-1.16.0-SNAPSHOT-bin.tar.gz ./minifi/minifi-assembly/target/minifi-1.16.0-SNAPSHOT-bin.tar.gz ./nifi-registry/nifi-registry-toolkit/nifi-registry-toolkit-assembly/target/nifi-registry-toolkit-1.16.0-SNAPSHOT-bin.tar.gz ./nifi-registry/nifi-registry-assembly/target/nifi-registry-1.16.0-SNAPSHOT-bin.tar.gz ./nifi-stateless/nifi-stateless-assembly/target/nifi-stateless-1.16.0-SNAPSHOT-bin.tar.gz nifi % nifi % mvn clean install -DskipTests -Ddir-only ... nifi % find . -name "*bin.zip" ./nifi-toolkit/nifi-toolkit-assembly/target/nifi-toolkit-1.16.0-SNAPSHOT-bin.zip ./minifi/minifi-c2/minifi-c2-assembly/target/minifi-c2-1.16.0-SNAPSHOT-bin.zip ./minifi/minifi-toolkit/minifi-toolkit-assembly/target/minifi-toolkit-1.16.0-SNAPSHOT-bin.zip ./nifi-registry/nifi-registry-toolkit/nifi-registry-toolkit-assembly/target/nifi-registry-toolkit-1.16.0-SNAPSHOT-bin.zip ./nifi-registry/nifi-registry-extensions/nifi-registry-aws/nifi-registry-aws-assembly/target/nifi-registry-aws-assembly-1.16.0-SNAPSHOT-bin.zip ./nifi-registry/nifi-registry-extensions/nifi-registry-ranger/nifi-registry-ranger-assembly/target/nifi-registry-ranger-assembly-1.16.0-SNAPSHOT-bin.zip ./nifi-registry/nifi-registry-assembly/target/nifi-registry-1.16.0-SNAPSHOT-bin.zip nifi % find . -name "*bin.tar.gz" nifi % ``` I would expect the default build to emit ten zips, the `targz` profile to emit ten tgzs, and the "dir-only" switch to suppress the assembly of any instance of either. Is this test set correct? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
