exceptionfactory commented on pull request #5324: URL: https://github.com/apache/nifi/pull/5324#issuecomment-1036442470
Thanks for the additional discussion on this @markap14, @joewitt, and @markobean! Based on the direction of the discussion, I'm not inclined to merge the changes as they stand. However, I think there is value some of these features. Making the Schema File optional to support minimal well-formed XML checking is a useful improvement, so that would be helpful on its own. Regarding validation of XML attributes, what do you all think about a new `ValidateXmlAttribute` processor? The current `ValidateXml` processor is fairly simple as it stands, and separating attribute validation into a separate processor provides a clearer distinction of capability. I also noticed that the `getBytes()` call current has `UTF-8` hard-coded as the character set. Moving this handling to a separate processor provides the opportunity to make the character set a configurable property, which is not currently necessary when processing FlowFile content input streams. Although there may be some overlap in core schema validation functionality, having a separate `ValidateXmlAttribute` processor would follow the pattern of some other attribute-specific processors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
