lordgamez commented on a change in pull request #1253:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1253#discussion_r805990249
##########
File path: libminifi/src/FlowController.cpp
##########
@@ -431,8 +431,9 @@ int16_t FlowController::clearConnection(const std::string
&connection) {
return -1;
}
-std::shared_ptr<state::response::ResponseNode>
FlowController::getAgentManifest() const {
+std::shared_ptr<state::response::ResponseNode>
FlowController::getAgentManifest() {
auto agentInfo =
std::make_shared<state::response::AgentInformation>("agentInfo");
+
agentInfo->setUpdatePolicyController(std::static_pointer_cast<controllers::UpdatePolicyControllerService>(getControllerService(c2::C2Agent::UPDATE_NAME)));
Review comment:
Good point, I was a bit hesitant changing it because it was very low
core level stuff and I thought it would be convoluted, but after trying it, it
seems these controller provider getters could be made const quite easily.
Updated it in 5e37b8b76b97c6e04ee145c80293b5557348ba66
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
