markap14 commented on pull request #5247: URL: https://github.com/apache/nifi/pull/5247#issuecomment-1041928487
Thanks for your thoughts @joewitt and @mcgilman. Here's my 2 cents: - I'm not the one to review the code because my JavaScript skills are non-existent, so I can't review from that perspective. - The calls that the UI makes are to the existing endpoints, which asynchronously enable/disable controller services. So I don't think we have concerns about high load causing timeouts, failures, etc. because it shouldn't block - I do agree with mcgilman that I'd like to see a UI that allows the controller services to be visualized with all referencing components so that users know exactly what they are doing when they Disable All. And when enabling, ideally it would be helpful to be able to choose to start referencing components as well. - That said, I think this feature is extremely useful as-is. The more powerful UI capability can still be provided in a future release of NiFi, but I think this is significantly more helpful than what we have currently. So while I'm not in a position to review the code I'm a +1 personally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
