szaszm commented on a change in pull request #1263:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1263#discussion_r808432656
##########
File path: libminifi/test/unit/TimeUtilTests.cpp
##########
@@ -98,8 +98,9 @@ TEST_CASE("Test time conversion", "[testtimeconversion]") {
TEST_CASE("Test system_clock epoch", "[systemclockepoch]") {
using namespace std::chrono;
+ using namespace date;
time_point<system_clock> epoch;
- time_point<system_clock> unix_epoch_plus_3e9_sec = sys_days(January / 24 /
2065) + 5h + 20min;
+ time_point<system_clock> unix_epoch_plus_3e9_sec =
date::sys_days(date::January / 24 / 2065) + 5h + 20min;
Review comment:
The issue: libstdc++10 doesn't implement month objects in std::chrono.
Version 11 has them, which is why it's passing in GH actions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
