mcgilman commented on a change in pull request #5765:
URL: https://github.com/apache/nifi/pull/5765#discussion_r809435463
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-label.js
##########
@@ -527,7 +538,7 @@
// update
var updated = selection.merge(entered);
- updated.call(updateLabels).call(nfCanvasUtils.position,
transition);
+ updated.call(updateLabels).call(nfCanvasUtils.position,
transition).call(sort);
Review comment:
We also need to introduce a call to `sort` in `add`. When a new Label is
created, it's z-index will be 0. If it is placed directly on top of another
Label that already has an established z-index we need to ensure this is
rendered below. By default, it will render on top because it was added to the
DOM later. If you try this out, you'll see it renders on top until the canvas
polls which triggers a call to `update` that will re-sort and move the new
Label below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
