adam-markovics commented on a change in pull request #1264:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1264#discussion_r812022194



##########
File path: extensions/bustache/ApplyTemplate.cpp
##########
@@ -19,81 +19,76 @@
  */
 #include "ApplyTemplate.h"
 
-#include <iostream>
+#include <filesystem>
 #include <fstream>
+#include <iostream>
 #include <memory>
-#include <set>
 #include <string>
-
-#include <boost/iostreams/device/mapped_file.hpp>
-
-#include <bustache/model.hpp>
+#include <utility>
 
 #include "core/Resource.h"
+#include "bustache/model.hpp"
+
+namespace org::apache::nifi::minifi::processors {
+
+const core::Property ApplyTemplate::Template("Template", "Path to the input 
mustache template file", "");
+const core::Relationship ApplyTemplate::Success("success", "success 
operational on the flow record");
+
+namespace {
+class WriteCallback : public OutputStreamCallback {
+ public:
+  WriteCallback(std::filesystem::path templateFile, const core::FlowFile& 
flow_file)
+      :template_file_{std::move(templateFile)}, 
flow_file_{std::move(flow_file)}

Review comment:
       std::move does not have an effect on flow_file




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to