bejancsaba commented on a change in pull request #5762:
URL: https://github.com/apache/nifi/pull/5762#discussion_r813955423
##########
File path:
minifi/minifi-nar-bundles/minifi-framework-bundle/minifi-framework-nar/pom.xml
##########
@@ -79,6 +89,22 @@ limitations under the License.
<artifactId>nifi-security-utils-api</artifactId>
<scope>compile</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-security-utils</artifactId>
+ <scope>compile</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-framework-nar-loading-utils</artifactId>
+ <version>1.16.0-SNAPSHOT</version>
Review comment:
As a general question (maybe not in scope for this change) I saw that
dependency version for 1.16 is scattered everywhere would it make sense to
extract it so it could be updated / changed in only one place? What do you
think?
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-headless-server/src/main/java/org/apache/nifi/headless/HeadlessNiFiServer.java
##########
@@ -165,6 +168,16 @@ public void preDestruction() throws
AuthorizerDestructionException {
FlowManager flowManager = flowController.getFlowManager();
flowManager.getGroup(flowManager.getRootGroupId()).startProcessing();
+ final NarLoader narLoader = new StandardNarLoader(
Review comment:
So I tried it but was not able to make it work. I checked and in NiFi we
have this property defined which is missing from MiNiFI if I'm not mistaken:
nifi.nar.library.autoload.directory=./extensions
After some investigation it turned out that it doesn't help if I update the
properties file as it is generated based on the ConfigTransformer. I tried to
add the config there but even with that if a place anar into the extensions
dir I don't see any logs stating that the nar is picked up. Maybe something is
missing on my side but is it possible that some configuration is missing from
the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
