adamdebreceni commented on a change in pull request #1267:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1267#discussion_r814557828



##########
File path: extensions/http-curl/protocols/RESTSender.cpp
##########
@@ -161,6 +161,7 @@ C2Payload RESTSender::sendPayload(const std::string url, 
const Direction directi
     logger_->log_debug("Response code '" "%" PRId64 "' from '%s'", respCode, 
url);
   }
   const auto response_body_bytes = 
gsl::make_span(client.getResponseBody()).as_span<const std::byte>();
+  logger_->log_trace("Received response: \"%s\"", [&] {return 
utils::StringUtils::escapeUnprintableBytes(response_body_bytes);});

Review comment:
       those utilities operate on the `C2Payload` level, which is one level too 
high if we want to debug possible malformed responses, IMO it has utility for 
the user to be able to inspect both the raw response and the agent processed 
(`C2Payload`) one




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to