tpalfy commented on a change in pull request #5802: URL: https://github.com/apache/nifi/pull/5802#discussion_r814910087
########## File path: nifi-nar-bundles/nifi-salesforce-bundle/nifi-salesforce-processors/src/test/java/org/apache/nifi/processors/salesforce/util/SalesforceConfigAware.java ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.processors.salesforce.util; + +import org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider; +import org.apache.nifi.reporting.InitializationException; +import org.apache.nifi.util.TestRunner; + +/** + * Set the following constants:<p> + * VERSION<p> + * BASE_URL<p> + * USERNAME<p> + * PASSWORD<p> + * CLIENT_ID<p> + * CLIENT_SECRET<p> + */ +public interface SalesforceConfigAware { + String VERSION = "46.0"; + String BASE_URL = "https://cloudera-2a-dev-ed.my.salesforce.com";; + + String AUTHORIZATION_SERVER_URL = BASE_URL + "/services/oauth2/token"; + String USERNAME = "???"; + String PASSWORD = "???"; + String CLIENT_ID = "???"; + String CLIENT_SECRET = "???"; Review comment: Hi @exceptionfactory, This is a collaboration work between me and @Lehel44 and I made this part. How we handle manual tests currently I would say this is the more convenient approach. Anyone who wants to run these tests needs to add these settings manually one way or another. As long as we don't have a more standardized way of providing configuration details to tests (so that they can become automatic) simply editing the classes themselves is the simplest and thus gives the best user experience. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
