szaszm commented on a change in pull request #1152:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1152#discussion_r816956520
##########
File path: libminifi/test/SingleInputTestController.h
##########
@@ -34,9 +34,11 @@ class SingleInputTestController : public TestController {
{}
std::unordered_map<core::Relationship,
std::vector<std::shared_ptr<core::FlowFile>>>
- trigger(const std::string_view input_flow_file_content,
std::unordered_map<std::string, std::string> input_flow_file_attributes = {}) {
- const auto new_flow_file = createFlowFile(input_flow_file_content,
std::move(input_flow_file_attributes));
- input_->put(new_flow_file);
+ trigger(const std::optional<std::string_view> input_flow_file_content,
std::unordered_map<std::string, std::string> input_flow_file_attributes = {}) {
+ if (input_flow_file_content) {
Review comment:
It's not about the number of flow files, but the number of connections,
you are right. There can be multiple flow files, but I meant to test behavior
on incoming flow files. I think the flow file content should stay mandatory
here.
I like the changes you made in 4048d55. It still makes the class
multi-purpose but it's at least separated enough and quite simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
