gresockj commented on a change in pull request #5822:
URL: https://github.com/apache/nifi/pull/5822#discussion_r817779164
##########
File path:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/test/groovy/org/apache/nifi/elasticsearch/integration/ElasticSearchClientService_IT.groovy
##########
@@ -223,9 +226,13 @@ class ElasticSearchClientService_IT {
@Test
void testSearchWarnings() {
+ Assume.assumeTrue("Requires version <8.0 (no search API deprecations
yet for 8.x)", VERSION < ES_8_0)
+
String query
String type = TYPE
- if (VERSION.toString().startsWith("7.")) {
+ if (VERSION.toString().startsWith("8.")) {
+ // TODO: something that's deprecated when the 8.x branch
progresses to include search-API deprecations
Review comment:
Thanks for the elaboration -- in light of that, I think we should keep
the TODO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
