exceptionfactory commented on a change in pull request #5841:
URL: https://github.com/apache/nifi/pull/5841#discussion_r824916388
##########
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-event-transport/src/main/java/org/apache/nifi/event/transport/netty/channel/StandardChannelInitializer.java
##########
@@ -37,6 +39,8 @@
private Duration writeTimeout = Duration.ofSeconds(30);
+ private Duration idleTimeout = Duration.ofSeconds(30);
Review comment:
As in the `NettyEventSenderFactory`, it seems like the internal default
should be `0`.
##########
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-event-transport/src/main/java/org/apache/nifi/event/transport/netty/NettyEventSenderFactory.java
##########
@@ -61,6 +61,8 @@
private Duration timeout = Duration.ofSeconds(30);
+ private Duration idleTimeout = Duration.ofSeconds(30);
Review comment:
It seems like the internal default should be `0` given that no idle
timeout is the current internal behavior of this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
