mattyb149 commented on pull request #5830: URL: https://github.com/apache/nifi/pull/5830#issuecomment-1066178696
I believe it was for two reasons: 1) To allow for Invocable engines when they didn't compile the script. That's slower but if there are engines that do that we didn't want to exclude them. Looking at the existing engines I think we could use CompiledScript but I kind of recall that something like `eval(Bindings)` didn't actually update the bindings on the compiled script for some engine(s). Please feel free to look into switching to CompiledScript over Invocable if that's not the case. 2) To call methods not on the interface but useful for the scripted component, like `setLogger()`. Not sure we could do that with a CompiledScript.eval(), but maybe we can take a different approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
