martinzink commented on a change in pull request #1268:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1268#discussion_r828276071



##########
File path: docker/test/integration/steps/steps.py
##########
@@ -417,6 +425,25 @@ def step_impl(context):
     context.test.cluster.enable_splunk_hec_ssl('splunk', 
dump_certificate(splunk_cert), dump_privatekey(splunk_key), 
dump_certificate(root_ca_cert))
 
 
+@given(u'{processor_one} processor is set up with a 
GcpCredentialsControllerService to communicate with the Google Cloud storage 
server')
+def step_impl(context, processor_one):
+    gcp_controller_service = 
GcpCredentialsControllerService(credentials_location="Use Anonymous 
credentials")
+    p1 = context.test.get_node_by_name(processor_one)
+    p1.controller_services.append(gcp_controller_service)
+    p1.set_property("GCP Credentials Provider Service", 
gcp_controller_service.name)
+
+
+@given(u'{processor_one} processor and {processor_two} processor are set up 
with a GcpCredentialsControllerService to communicate with the Google Cloud 
storage server')

Review comment:
       good catch (this whole docker testing was backported from an upcoming 
ticket)
   removed it 
https://github.com/apache/nifi-minifi-cpp/commit/0492f5b7b49235d69d23c34d3762176bd1f9448a#diff-dce84c359f2f7128e501f5a322d8f6ac3325c2b471844f2c42cbef9abca58185L436

##########
File path: docker/test/integration/features/google_cloud_storage.feature
##########
@@ -0,0 +1,19 @@
+Feature: Sending data to Google Cloud Storage using PutGcsObject
+
+  Background:
+    Given the content of "/tmp/output" is monitored
+
+  Scenario: A MiNiFi instance can upload data to Google Cloud storage
+    Given a GetFile processor with the "Input Directory" property set to 
"/tmp/input"
+    And a file with the content "hello_gcs" is present in "/tmp/input"
+    And a Google Cloud storage server is set up
+    And a PutGcsObject processor
+    And PutGcsObject processor is set up with a 
GcpCredentialsControllerService to communicate with the Google Cloud storage 
server
+    And a PutFile processor with the "Directory" property set to "/tmp/output"
+    And the "success" relationship of the GetFile processor is connected to 
the PutGcsObject
+    And the "success" relationship of the PutGcsObject processor is connected 
to the PutFile
+
+    When all instances start up
+
+    Then a flowfile with the content "hello_gcs" is placed in the monitored 
directory in less than 45 seconds
+    And object with the content "hello_gcs" is present in the Google Cloud 
storage

Review comment:
       :+1: you are right changed it in
   
https://github.com/apache/nifi-minifi-cpp/commit/0492f5b7b49235d69d23c34d3762176bd1f9448a#diff-3ab103da2d90c3f0112fc801f20ff591790df7190fd3785e2bdef1254f95ab98R19




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to