exceptionfactory commented on a change in pull request #5870:
URL: https://github.com/apache/nifi/pull/5870#discussion_r828496874
##########
File path:
nifi-nar-bundles/nifi-ranger-bundle/nifi-ranger-plugin/src/test/java/org/apache/nifi/ranger/authorization/TestRangerNiFiAuthorizer.java
##########
@@ -200,19 +181,7 @@ public void testKerberosEnabled() {
authorizer = new MockRangerNiFiAuthorizer(rangerBasePlugin);
authorizer.setNiFiProperties(nifiProperties);
- AuthorizerCreationException e =
assertThrows(AuthorizerCreationException.class,
- () -> authorizer.onConfigured(configurationContext));
- // getting a LoginException here means we attempted to login which is
what we want
- boolean foundLoginException = false;
- Throwable cause = e.getCause();
- while (cause != null) {
- if (cause instanceof LoginException) {
- foundLoginException = true;
- break;
- }
- cause = cause.getCause();
- }
- assertTrue(foundLoginException);
+ assertThrows(AuthorizerCreationException.class, () ->
authorizer.onConfigured(configurationContext));
Review comment:
Yes, this does make the test looser in terms of expected exception
checking. There appear to be other issues with Ranger and Java 17, so the other
option is marking several of these methods as ignored on Java 17, but it seemed
better to make the tests somewhat more general in this scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
