greyp9 commented on a change in pull request #5871:
URL: https://github.com/apache/nifi/pull/5871#discussion_r828492708
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java
##########
@@ -604,17 +604,28 @@ private void executeDML(final ProcessContext context,
final ProcessSession sessi
}
final SchemaKey schemaKey = new PutDatabaseRecord.SchemaKey(catalog,
schemaName, tableName);
- final TableSchema tableSchema = schemaCache.get(schemaKey, key -> {
- try {
- final TableSchema schema = TableSchema.from(con, catalog,
schemaName, tableName, settings.translateFieldNames, updateKeys, log);
- getLogger().debug("Fetched Table Schema {} for table name {}",
schema, tableName);
- return schema;
- } catch (SQLException e) {
- throw new ProcessException(e);
+ final TableSchema tableSchema;
Review comment:
Could line 607 go inside the try?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
