szaszm commented on a change in pull request #1280:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1280#discussion_r831206143
##########
File path: extensions/http-curl/tests/HTTPHandlers.h
##########
@@ -792,20 +792,40 @@ class C2AcknowledgeHandler : public ServerAwareHandler {
rapidjson::Document root;
root.Parse(req.data(), req.size());
if (root.IsObject() && root.HasMember("operationId")) {
- std::lock_guard<std::mutex> guard(mtx_);
+ std::lock_guard<std::mutex> guard(ack_operations_mtx_);
Review comment:
`ack_operations_mtx_` is released before locking `apply_count_mtx_`, so
they are never locked at the same time. Since only one is held at a time, it's
not possible that this function and another thread are waiting for each other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
