Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/50#discussion_r86619586
--- Diff:
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/ConnectionSchema.java
---
@@ -50,21 +49,18 @@
private String queuePrioritizerClass;
public ConnectionSchema(Map map) {
- super(map, CONNECTIONS_KEY);
+ super(map, "Connection(id: {id}, name: {name})");
+ String wrapperName = getWrapperName();
// In case of older version, these may not be available until
after construction, validated in getValidationIssues()
- sourceId = getOptionalKeyAsType(map, SOURCE_ID_KEY, String.class,
CONNECTIONS_KEY, "");
- destinationId = getOptionalKeyAsType(map, DESTINATION_ID_KEY,
String.class, CONNECTIONS_KEY, "");
-
- sourceRelationshipNames = getOptionalKeyAsType(map,
SOURCE_RELATIONSHIP_NAMES_KEY, List.class, CONNECTIONS_KEY, new ArrayList<>());
- if (sourceRelationshipNames.isEmpty()) {
- addValidationIssue("Expected at least one value in " +
SOURCE_RELATIONSHIP_NAMES_KEY + " for " + CONNECTIONS_KEY + " " + getName());
- }
-
- maxWorkQueueSize = getOptionalKeyAsType(map,
MAX_WORK_QUEUE_SIZE_KEY, Number.class, CONNECTIONS_KEY,
DEFAULT_MAX_WORK_QUEUE_SIZE);
- maxWorkQueueDataSize = getOptionalKeyAsType(map,
MAX_WORK_QUEUE_DATA_SIZE_KEY, String.class, CONNECTIONS_KEY,
DEFAULT_MAX_QUEUE_DATA_SIZE);
- flowfileExpiration = getOptionalKeyAsType(map,
FLOWFILE_EXPIRATION__KEY, String.class, CONNECTIONS_KEY,
DEFAULT_FLOWFILE_EXPIRATION);
- queuePrioritizerClass = getOptionalKeyAsType(map,
QUEUE_PRIORITIZER_CLASS_KEY, String.class, CONNECTIONS_KEY, "");
+ sourceId = getOptionalKeyAsType(map, SOURCE_ID_KEY, String.class,
wrapperName, "");
+ destinationId = getOptionalKeyAsType(map, DESTINATION_ID_KEY,
String.class, wrapperName, "");
+
+ sourceRelationshipNames = getOptionalKeyAsType(map,
SOURCE_RELATIONSHIP_NAMES_KEY, List.class, wrapperName, new ArrayList<>());
--- End diff --
Could you add a comment explaining that this could be empty if the source
is a port?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
